-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CO-1748] Settings filter #755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests for it - add ActionFileInto type
- this input supports only one value!
- the test is a bit weak but it's better than testing many things together
- custom select can accept undefined values - find from lodash has been replace with standard find as the return type was incompatible but the behavior should be the same
…o incoming - apply action is defined only on incoming filters
…ed to fix API types
…ved old APIs from actions to APIs
- decided to move tests there since that is where the logic lies
…nent without having to use any
- there are issues with 'act' that I am not able to fix yet
- it would be a better idea to split the component
|
frisonisland
approved these changes
Jan 17, 2025
giuliano176
approved these changes
Jan 17, 2025
keshavbhatt
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.